Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change security externalIdentifierType in example #716

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

rnjudge
Copy link
Collaborator

@rnjudge rnjudge commented Apr 14, 2024

Update the Vulnerability class syntax example to change the externalIdentifierType from securityOther to securityAdvisory for a GitHub advisory because it references a well known advisory source.

Thanks @puerco for catching this.

Update the Vulnerability class syntax example to change the
externalIdentifierType from securityOther to securityAdvisory for a
GitHub advisory because it references a well known advisory source.

Thanks @puerco for catching this.

Signed-off-by: Rose Judge <rose.judge@broadcom.com>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fixing example

@kestewart kestewart merged commit d4a4f84 into spdx:main Apr 14, 2024
1 check passed
Copy link
Collaborator

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants