Add API to get version information #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SpdxVersion class to store and handle version information of tools, library and license list. Signed-off-by: Hirumal Priyashan <hirupriyashanrc@gmail.com>
goneall
reviewed
Feb 20, 2023
There was a problem hiding this comment.
Thanks @HirumalPriyashan - The changes look good.
There is one enhancement I was thinking of adding independent of the API request.
It would be nice to get the version from the POM file - that way we don't have to manually update it in the code. Now that the code is nicely structured for the version API, it might be a good opportunity to add this feature.
I found this stack overflow article describing an approach.
Let me know if you'd like to attempt the change as part of this PR. We can also merge this in and make a second issue/PR if you prefer.
Add programmatically retrieving version number from `pom.xml` Signed-off-by: Hirumal Priyashan <hirupriyashanrc@gmail.com>
|
I have added suggested feature to this PR. |
goneall
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Thanks @HirumalPriyashan - changes look good and works well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SpdxVersion class to store and handle version information of tools, library and license list.