Showing line no. of error in tag value by throwing expections. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceptions. * It still shows 2 exceptions when it is an invalid file. One for Tag Value Exception and one for RDF. Signed-off-by: rtgdk <rohit.lodhartg@gmail.com>
|
@goneall Can we differentiate between an error of invalid file format and invalid tag value file when calling HandBuiltParser? We can check which type of error it is and throw only the required error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added try catch in TagToRDF for returning line no. of error by throwing exceptions when executing HandBuiltParser.
It still shows 2 exceptions when it is an invalid file. One for Tag Value Exception and one for RDF.
So when we pass an invalid file format or an invalid TagValue or invalid RDF file, it will combine 2 exception together. It needs to fixed.