Allow None value in boolean converter

spec-first · Jan 4, 2016 · 41df524 · 41df524
1 parent 754c250
commit 41df524
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/connexion/utils.py b/connexion/utils.py
@@ -131,7 +131,9 @@ def boolean(s):
     >>> boolean('false')
     False
     '''
-    if s.lower() == 'true':
+    if not hasattr(s, 'lower'):
+        raise ValueError('Invalid boolean value')
+    elif s.lower() == 'true':
         return True
     elif s.lower() == 'false':
         return False

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -41,3 +41,6 @@ def test_boolean():
 
     with pytest.raises(ValueError):
         utils.boolean('foo')
+
+    with pytest.raises(ValueError):
+        utils.boolean(None)