minor refactor of properties

connexion/operations/abstract.py

@@ -99,6 +99,8 @@ def __init__(self, api, method, path, operation, resolver,
         self._resolution = resolver.resolve(self)
         self._operation_id = self._resolution.operation_id
 
+        self._responses = self._operation.get("responses", {})
+
         self._validator_map = dict(VALIDATOR_MAP)
         self._validator_map.update(validator_map or {})
 
@@ -116,6 +118,13 @@ def path(self):
         """
         return self._path
 
+    @property
+    def responses(self):
+        """
+        Returns the responses for this operation
+        """
+        return self._responses
+
     @property
     def validator_map(self):
         """
@@ -226,12 +235,6 @@ def parameters(self):
         Returns the parameters for this operation
         """
 
-    @abc.abstractproperty
-    def responses(self):
-        """
-        Returns the responses for this operation
-        """
-
     @abc.abstractproperty
     def produces(self):
         """

connexion/operations/openapi.py

@@ -101,7 +101,7 @@ def component_get(oas3_name):
             }
         }
 
-        self._request_body = operation.get('requestBody')
+        self._request_body = operation.get('requestBody', {})
 
         self._parameters = operation.get('parameters', [])
         if path_parameters:
@@ -112,13 +112,12 @@ def component_get(oas3_name):
         # TODO figure out how to support multiple mimetypes
         # NOTE we currently just combine all of the possible mimetypes,
         #      but we need to refactor to support mimetypes by response code
-        response_codes = operation.get('responses', {})
         response_content_types = []
-        for _, defn in response_codes.items():
+        for _, defn in self._responses.items():
             response_content_types += defn.get('content', {}).keys()
         self._produces = response_content_types or ['application/json']
 
-        request_content = operation.get('requestBody', {}).get('content', {})
+        request_content = self._request_body.get('content', {})
         self._consumes = list(request_content.keys()) or ['application/json']
 
         logger.debug('consumes: %s' % self.consumes)
@@ -147,10 +146,6 @@ def request_body(self):
     def parameters(self):
         return self._parameters
 
-    @property
-    def responses(self):
-        return self._responses
-
     @property
     def consumes(self):
         return self._consumes
@@ -159,10 +154,6 @@ def consumes(self):
     def produces(self):
         return self._produces
 
-    @property
-    def _spec_definitions(self):
-        return self._definitions_map
-
     def with_definitions(self, schema):
         if self.components:
             schema['schema']['components'] = self.components

connexion/operations/swagger2.py

@@ -141,10 +141,6 @@ def from_spec(cls, spec, api, path, method, resolver, *args, **kwargs):
     def parameters(self):
         return self._parameters
 
-    @property
-    def responses(self):
-        return self._responses
-
     @property
     def consumes(self):
         return self._consumes