-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest>=5.0.0 incompatible with Flask<=1.0.4 #991
Comments
Thanks for reporting, so just updating Flask would fix the problem? |
@hjacobs especially pinning to |
In a defense of this approach, may I be so bold to say that dropping older Flask opens door to support newer Python that is not only faster but also typed which makes it extremely easier to maintain larger projects. |
@hjacobs it did the trick for me. All we need to test IT is the PR. I will drop one later on. |
Great, thanks! |
Description
Master builds are failing due to error:
This can be tracked to following issues:
Indeed (either one of those actions):
flask
to be at least1.0.4
makes tests pass.pytest
to be at most4.9.x
makes test passWhich brings us down to final question.
Should
Flask
be kept at low version (which is pretty old TBH) or shouldpytest
be restricted.Personally I favor running newer version instead of supporting older codebases.
Expected behaviour
master branch builds correctly against
min
environments.Actual behaviour
master branch builds correctly against
min
fail with aforementioned error.Steps to reproduce
Just run
tox -e py3(X)-min
whereX
stands forPython
minor version {4,5,6,7}.The text was updated successfully, but these errors were encountered: