Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flask to be at least 1.0.4 #995

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Conversation

kornicameister
Copy link
Contributor

Fixes #991 .

Changes proposed in this pull request:

  • bump flask to be at least 1.0.4

Reasons:

  • flask==0.10.1 was released in 2013, which makes it quite old thus unsupported.
  • On Flask webpage you can find an information pointing to 1.x branch as latest stable
  • different tools, including these used in connexion progressed leaving Python versions, for which flask<1.0 has been developed.

Reasons:
- `flask==0.10.1` was released in 2013, which makes it quite old thus unsupported.
- On Flask webpage you can find an information pointing to `1.x` branch as latest stable
- different tools, including these used in `connexion` progressed leaving Python versions, for which `flask<1.0` has been developed.
@kornicameister
Copy link
Contributor Author

cc @hjacobs

@kornicameister
Copy link
Contributor Author

kornicameister commented Jul 8, 2019

Hmm...

E       pytest.PytestDeprecationWarning: The 'message' parameter is deprecated.
E       (did you mean to use `match='some regex'` to check the exception message?)
E       Please see:
E         https://docs.pytest.org/en/4.6-maintenance/deprecations.html#message-parameter-of-pytest-raises

but that's unrelated to flask change. I guess we gotta change some tests as well to use this match.
I will create another issue and fix'em in separate PR to make changes atomic. Though, it might be needed to bump pytest. For Python2.7 older version of pytest is being installed which does not emit this error.

@hjacobs any suggestions as how to proceed with that?

@hjacobs
Copy link
Contributor

hjacobs commented Jul 9, 2019

Does it work when switching to the match parameter?

@kornicameister
Copy link
Contributor Author

@hjacobs it passed for 2.7, 3.4, 3.5, 3.6 and 3.7 versions. Should I just add the changes to this PR?

@hjacobs
Copy link
Contributor

hjacobs commented Jul 9, 2019

@kornicameister yes

@kornicameister
Copy link
Contributor Author

@hjacobs it went perfectly ok :)

@hjacobs
Copy link
Contributor

hjacobs commented Jul 9, 2019

@kornicameister thanks!

@hjacobs
Copy link
Contributor

hjacobs commented Jul 9, 2019

👍

@hjacobs hjacobs merged commit f99e39b into spec-first:master Jul 9, 2019
@kornicameister kornicameister deleted the patch-1 branch July 9, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest>=5.0.0 incompatible with Flask<=1.0.4
2 participants