Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: aiohttp access_log duplicated if passed as argument #1113

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Fix: aiohttp access_log duplicated if passed as argument #1113

merged 1 commit into from
Dec 25, 2019

Conversation

pando85
Copy link
Contributor

@pando85 pando85 commented Dec 24, 2019 •
edited
Loading

  • Pop access_log option from aiohttp options
  • Add test to access_log options in aiohttp run

@pando85
Fix: aiohttp access_log duplicated if passed as argument
917956c 
  - Pop access_log option from aiohttp options
  - Add test to access_log options in aiohttp run
@hjacobs
Copy link
Contributor

hjacobs commented Dec 25, 2019

👍

@hjacobs hjacobs merged commit 2886067 into spec-first:master Dec 25, 2019
@pando85 pando85 deleted the fix/python3.8-aiohttp-access_log branch December 25, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pando85 @hjacobs