Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jsonschema #114

Merged
merged 7 commits into from
Dec 21, 2015
Merged

Use jsonschema #114

merged 7 commits into from
Dec 21, 2015

Conversation

jmcs
Copy link
Contributor

@jmcs jmcs commented Dec 10, 2015

No description provided.

@hjacobs
Copy link
Contributor

hjacobs commented Dec 11, 2015

Could you raise the code coverage? Such an important change should have good test coverage 😄

Also we need to test and review it very thoroughly.

@jmcs
Copy link
Contributor Author

jmcs commented Dec 11, 2015

The coverage went down because I removed lots of code. The validation decorator is actually 100% tested.

ainmosni added a commit that referenced this pull request Dec 21, 2015
@ainmosni
Merge pull request #114 from zalando/json-schema
934e41d 
Use jsonschema
@ainmosni ainmosni merged commit 934e41d into master Dec 21, 2015
@jmcs jmcs removed the in progress label Dec 21, 2015
@ainmosni ainmosni deleted the json-schema branch December 21, 2015 09:41
@jmcs jmcs mentioned this pull request Feb 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ainmosni ainmosni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcs @hjacobs @ainmosni