Enforcedefaults aiohttp #1163
Merged
Enforcedefaults aiohttp #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjacobs
reviewed
Feb 20, 2020
| @@ -24,7 +23,9 @@ def __init__(self, | |||
|
|
|||
| @property | |||
| def json(self): | |||
| return self.json_getter() | |||
| if not hasattr(self, '_json'): | |||
There was a problem hiding this comment.
I think this change is unrelated to your example, why did you add it?
There was a problem hiding this comment.
It is related. Actually, it fixes the issue #1162. As opposed to FlaskApp, this code says that the body is recomputed each time we access ConnexionRequest.json. So if a validator changes the json, it is not reflected in the body argument because here it is recomputed again. This change avoids the recomputation and uses the same reference (which has been modified by the validator) again.
There was a problem hiding this comment.
Really, please try the example without this change and see that it behaves differently (the foo attribute is not added with the default value).
Pull Request Test Coverage Report for Build 1889774255
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1162 .
Changes proposed in this pull request:
ConnexionRequest.jsonproperty.