-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lifecycle: add cookies attribute to ConnexionRequest (#1168) #1209
lifecycle: add cookies attribute to ConnexionRequest (#1168) #1209
Conversation
Can you add unit tests? |
It looks to be only managed for Flask, is it also possible to make it for aiohttp. |
417ffb6
to
98e71e3
Compare
@hjacobs I rebased the commit on master + added unit tests in
@Sebastiencreoff I don't know enough about aiohttp to help here, could you test it with an actual application ? AFAICT the unit tests in |
FYI: aiohttp tests are in |
98e71e3
to
527ce20
Compare
Rebased on master, added an unit test for aiohttp. |
@hjacobs is something else needed to merge this ? |
Thanks for the bugfix! |
527ce20
to
e476552
Compare
I'm having troubles with the issue this PR is fixing. Is there anything left preventing it from being merged ? |
@HellDryx It seems that the repository has become inactive ;( |
e476552
to
9960d2e
Compare
9960d2e
to
ff0fbee
Compare
@rafaelcaricio @Ruwann @RobbeSneyders sorry to ping you like this but I don't know how to ask for a new review / approval to merge. I've updated the PR to use |
ff0fbee
to
a577307
Compare
a577307
to
2a9f405
Compare
Pull Request Test Coverage Report for Build 1889829072
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @noirbee!
Fixes #1168.
Changes proposed in this pull request:
cookies
attribute tolifecycle.ConnexionRequest
flask.Request.cookies
andaiohttp.web.Request.cookies