lifecycle: add cookies attribute to ConnexionRequest (#1168)

[noirbee]

Fixes #1168.

Changes proposed in this pull request:

• Add a cookies attribute to lifecycle.ConnexionRequest
• Use flask.Request.cookies and aiohttp.web.Request.cookies

[coveralls]

Coverage increased (+0.001%) to 96.877% when pulling 527ce20 on noirbee:fix/connexionrequest-cookies-attribute-1168 into 8830d56 on zalando:master.

[hjacobs]

Can you add unit tests?

[Sebastiencreoff]

It looks to be only managed for Flask, is it also possible to make it for aiohttp.
As I also need this change, how can I participate to it to have this feature ?

[noirbee]

Can you add unit tests?

@hjacobs I rebased the commit on master + added unit tests in tests/api/test_parameters.py

It looks to be only managed for Flask, is it also possible to make it for aiohttp.
As I also need this change, how can I participate to it to have this feature ?

@Sebastiencreoff I don't know enough about aiohttp to help here, could you test it with an actual application ? AFAICT the unit tests in tests/api/ only cover Flask app. I looked at the server API reference and it's basically the same as Flask (a MultiDict) so I expect the behaviour to be identical.

[dtkav]

FYI: aiohttp tests are in tests/aiohttp

[noirbee]

Rebased on master, added an unit test for aiohttp.

[noirbee]

Rebased on master, added an unit test for aiohttp.

@hjacobs is something else needed to merge this ?

[joe42]

Thanks for the bugfix!
Is there anything I can help with to get this merged?

[HellDryx]

I'm having troubles with the issue this PR is fixing. Is there anything left preventing it from being merged ?

[joe42]

@HellDryx It seems that the repository has become inactive ;(

[noirbee]

@rafaelcaricio @Ruwann @RobbeSneyders sorry to ping you like this but I don't know how to ask for a new review / approval to merge.

I've updated the PR to use async instead of @asyncio.coroutine in the aiohttp tests, and switched the base to main.

[coveralls]

Pull Request Test Coverage Report for Build 1889829072

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 96.748%

---

Totals
Change from base Build 1883321425:	0.003%
Covered Lines:	2886
Relevant Lines:	2983

---

💛 - Coveralls

[RobbeSneyders]

Thx @noirbee!