Render correct template in API #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess you mean |
|
Good catch! Updated. |
Ruwann
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Does it make sense to add a test for this? Would be nice imo, but I don't see a good way of testing this at first sight as it seems to be about the extra static content that is loaded when /ui is called that isn't rendered, while the page itself returns a 200 response
RobbeSneyders
force-pushed
the
bugfix/blueprint-template
branch
from
974c9de
to
c74cfa8
Compare
|
I think adding a test for this isn't straightforward indeed, and don't think it's worth the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1289.
#1289 (comment) for more info.
I also included a commit which cleans up an unused constant which I noticed while debugging this issue.