Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump upperbound version for jsonschema to 5.0.0 #1447

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Bump upperbound version for jsonschema to 5.0.0 #1447

merged 3 commits into from
Jan 29, 2022

Conversation

RobbeSneyders
Copy link
Member

Fixes #1430

Changes proposed in this pull request:

  • Drop usage of private jsonschema modules to prevent breaking on non-major version changes.
  • Create validate_defaults function by passing in the instance_validator instead of using an attribute on the OpenApiValidator. This is necessary since the attribute is no longer maintained while the validator descends into the spec. I presume due to the usage of attrs.resolve by jsonschema.

@coveralls
Copy link

coveralls commented Jan 16, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 97.049% when pulling 207f9ff on feature/jsonschema-4.0.0 into 425d5d5 on main.

@RobbeSneyders RobbeSneyders mentioned this pull request Jan 18, 2022
Closed
Ruwann
Ruwann approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!
Left a small comment on the docstring format

connexion/spec.py Outdated Show resolved Hide resolved
@RobbeSneyders
Create validate_defaults function by passing in the instance_validator
207f9ff 
The instance_validator was previously set as an attribute on the
OpenApiValidator. However with the jsonschema upgrade to 4.0.0, this
attribute is no longer maintained while descending into the spec.
Presumably because jsonschema now relies on attrs.resolve.
@patrickelectric
Copy link

Can we get this merged ?

@patrickelectric patrickelectric mentioned this pull request Jan 28, 2022
Merged
@RobbeSneyders RobbeSneyders merged commit 86af42d into main Jan 29, 2022
@patrickelectric
Copy link

Thanks!

@alex-zywicki
Copy link

When can we expect this to be released?

@Ruwann Ruwann deleted the feature/jsonschema-4.0.0 branch February 1, 2022 21:32
vbxx3 pushed a commit to Savannah-Group/connexion that referenced this pull request Apr 9, 2022
@RobbeSneyders @vbxx3
Bump upperbound version for jsonschema to 5.0.0 (spec-first#1447)
53253b2 
* Drop usage of private jsonschema modules

* Bump upper boundry for jsonschema version to 5.0.0

* Create validate_defaults function by passing in the instance_validator

The instance_validator was previously set as an attribute on the
OpenApiValidator. However with the jsonschema upgrade to 4.0.0, this
attribute is no longer maintained while descending into the spec.
Presumably because jsonschema now relies on attrs.resolve.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support jsonschema >= 4.0.0
5 participants
@RobbeSneyders @coveralls @patrickelectric @alex-zywicki @Ruwann