Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test release trigger to tags #1456

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

RobbeSneyders
Copy link
Member

The test release pipeline failed after merging #1454 because you can only upload a package on PyPi with the same version once.

This PR changes the trigger for the test release pipeline to tags, so it only runs when there's a new version.

This way, releasing works as follows:

  1. Push tag
  2. Test release pipeline
  3. Publish release
  4. Release pipeline

@coveralls
Copy link

coveralls commented Feb 7, 2022

Pull Request Test Coverage Report for Build 1809491406

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.053%

Totals Coverage Status
Change from base Build 1809057982: 0.0%
Covered Lines: 2832
Relevant Lines: 2918

💛 - Coveralls

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, another option could be to replace version by the commit SHA when publishing to Test PyPI and still run on every push to main?

@RobbeSneyders
Copy link
Member Author

A commit SHA is unfortunately not a valid version. See PEP 440.

@RobbeSneyders RobbeSneyders merged commit c362489 into main Feb 8, 2022
@RobbeSneyders RobbeSneyders deleted the bugfix/test-release branch February 8, 2022 12:22
vbxx3 pushed a commit to Savannah-Group/connexion that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants