Take into account (x-)nullable when validating defaults #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
force-pushed
the
bugfix/nullable-defaults
branch
from
c3c8e8c
to
842bb4d
Compare
Pull Request Test Coverage Report for Build 1853825683
💛 - Coveralls |
Ruwann
reviewed
Feb 17, 2022
| 'type': allow_nullable(Draft4Validator.VALIDATORS['type']), | ||
| 'enum': allow_nullable(Draft4Validator.VALIDATORS['enum']), | ||
| 'type': NullableTypeValidator, | ||
| 'enum': NullableTypeValidator, |
There was a problem hiding this comment.
This should actually be NullableEnumValidator:
Suggested change
| 'enum': NullableTypeValidator, | |
| 'enum': NullableEnumValidator, |
Ruwann
reviewed
Feb 17, 2022
| @@ -67,3 +67,16 @@ paths: | |||
| description: User object | |||
| schema: | |||
| $ref: '#/definitions/User' | |||
|
|
|||
| /nullable_default: | |||
There was a problem hiding this comment.
Is this endpoint actually tested? The added test doesn't seem to call it? Or is it purely the loading of the spec itself that caused issues?
There was a problem hiding this comment.
It's the loading of the spec, since the validation of the spec itself failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1462.
CC: @nielsbox