Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save memory on unused schema strings #1482

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Save memory on unused schema strings #1482

merged 1 commit into from
Mar 10, 2022

Conversation

vmarkovtsev
Copy link
Contributor

Nodoby needs the schema strings vs. the parsed contents, yet those strings consume quite some memory for big specs.

@vmarkovtsev
Save memory on unused schema strings
bb68b3b 
Nodoby needs the schema strings vs. the parsed contents, yet those strings consume quite some memory for big specs.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1964265240

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 96.788%
Totals Coverage Status
Change from base Build 1946858000: 0.002%
Covered Lines: 2893
Relevant Lines: 2989
💛 - Coveralls

RobbeSneyders
RobbeSneyders approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @vmarkovtsev!

@RobbeSneyders RobbeSneyders merged commit 28c33d8 into spec-first:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmarkovtsev @coveralls @RobbeSneyders