Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only warn about the schema's x-body-name being deprecated if it's used. #1554

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Only warn about the schema's x-body-name being deprecated if it's used. #1554

merged 1 commit into from
Jun 14, 2022

Conversation

lanzkron
Copy link
Contributor

Fixes #1520

Resubmitting PR #1550 which got bogged down in git issues

Changes proposed in this pull request:

  • Code behaviour is unchanged, if body name is set use it, otherwise fallback to the schema's (deprecated) name or "body" if nothing is set
  • If x-body-name is set in the schema, warn about deprecation and use (unless overridden by the request body).

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lanzkron!

@RobbeSneyders RobbeSneyders merged commit 1ce3e2e into spec-first:v2 Jun 14, 2022
@lanzkron lanzkron deleted the avoid-false-positive-deprecation-warning-regard-x-body-name branch June 14, 2022 11:31
RobbeSneyders pushed a commit that referenced this pull request Aug 29, 2022
…d. (#1554)

Co-authored-by: Motti Lanzkron <motti@microfocus.com>
RobbeSneyders pushed a commit that referenced this pull request Aug 30, 2022
…d. (#1554)

Co-authored-by: Motti Lanzkron <motti@microfocus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants