-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/method views args #1564
Feature/method views args #1564
Conversation
Pull Request Test Coverage Report for Build 2612518271
💛 - Coveralls |
Thanks @bluebrown, looks good to me. You do have an orphan commit because I rewrote history on main (to unsquash the black formatting so we can exclude it from history, #1561). It's not an issue, but it will add me as a co-author to this PR. You can rebase on main to remove it. |
Hi @RobbeSneyders, what do you mean by rebase on main? Do you mean I should squash these 3 commits into 1, in my branch? |
The first commit of your PR (9be473d) is outdated. The same changes are now added as separate commits on main. If you rebase on main, you should be able skip the first commit, only keeping the 2 relevant commits. |
Sorry, I don't know how to do that rebase on main. The only rebasing I know would be like below, on my feature branch.
|
Signed-off-by: Nico Braun <rainbowstack@gmail.com>
|
I have pulled the latest changes before branching. Right now, I cannot fetch upstream because there are no new changes. Pulling my own main, locally also says no changes, and $ connexion on feature/method-views-args via 🐍 v3.9.2 on ☁️ (eu-central-1) ❯ git rebase main
Current branch feature/method-views-args is up to date |
ec8fb28
to
9277559
Compare
Fixes #1563
Changes proposed in this pull request: