Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly support Flask async routes #1592

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

RobbeSneyders
Copy link
Member

Fixes #1529

Flask async routes were already supported due to the async logic used for aiohttp. This PR just makes it explicit by:

  • Installing Flask with the async extra.
    The additional asgiref dependency it adds is already a subdependency of connexion though, so in practice this has no effect.
  • Adding a test checking if async routes work

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3085233174

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 95.219%

Totals Coverage Status
Change from base Build 3078058780: 0.5%
Covered Lines: 2868
Relevant Lines: 3012

💛 - Coveralls

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobbeSneyders RobbeSneyders merged commit 024666d into main Sep 26, 2022
@RobbeSneyders RobbeSneyders deleted the feature/flask-async branch September 26, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Flask 2.X async routes
3 participants