Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart.rst to include example of passing server arguments #1645

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

rkrishnasanka
Copy link
Contributor

Changes proposed in this pull request:

  • Updated the docs such that it comes with an example for passing server arguments and serving static files

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I have made some small adjustments.
Full disclaimer: this will probably be changed when updating the docs to 3.0 :)

docs/quickstart.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4321318662

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 75 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+1.09%) to 93.238%

Files with Coverage Reduction New Missed Lines %
connexion/apps/abstract.py 1 93.33%
connexion/middleware/response_validation.py 1 98.59%
connexion/operations/openapi.py 1 94.87%
connexion/validators/form_data.py 1 92.86%
connexion/lifecycle.py 2 86.08%
connexion/operations/abstract.py 2 77.91%
connexion/security.py 2 83.54%
connexion/apps/asynchronous.py 3 95.16%
connexion/apps/flask.py 3 96.84%
connexion/operations/swagger2.py 3 95.33%
Totals Coverage Status
Change from base Build 4201806645: 1.09%
Covered Lines: 3268
Relevant Lines: 3505

💛 - Coveralls

@Ruwann Ruwann merged commit ab94e2a into spec-first:main Mar 3, 2023
@rkrishnasanka
Copy link
Contributor Author

No issues !

It took me like 24 hours to figure out how to pass the arguments, so I think it's important to highlight this in the documentation.

RobbeSneyders pushed a commit that referenced this pull request Mar 6, 2023
…1645)

Changes proposed in this pull request:
- Updated the docs such that it comes with an example for passing server
arguments and serving static files

---------

Co-authored-by: Ruwann <ruwan.lambrichts@ml6.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants