Add traceback info to common error handler #1708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still up for discussion: right now, when an internal server error occurs, the logged error is not really useful for the user.
For example, a
KeyError
will only print the missing key instead of the full stacktrace and error.Adding it to the common error handler as that one is meant to catch all remaining errors,
HTTPException
s are handled by another error handler.Another option would be to do like
Flask
andStarlette
by adding adebug
option, but that seems a lot of work while this current solution doesn't really have big downsides (?)