Add traceback info to common error handler #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
approved these changes
Jun 1, 2023
@Ruwann @RobbeSneyders I think it would it make sense to apply this same change to the two other ideas - in case dumping the exc_info is overkill for each HTTPException or ProblemException:
|
RobbeSneyders
pushed a commit
that referenced
this pull request
Jun 13, 2023
Follow-up on #1708 ([comment](#1708 (comment))) As mentioned there, there is a `__repr__` but not a `__str__`, leading to an empty log message (for HTTPExceptions). An example when running the dev server (previously the first line would just be an empty line): ``` HTTPException(status_code=404, detail='Not Found') INFO: 127.0.0.1:33538 - "GET /swaggers/ui/ HTTP/1.1" 404 Not Found ``` However, I would also be fine with just removing the logging here as `HTTPException`s can be part of the normal flow, without indicating an actual application error (case in point: raising a `Not Found` exception)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still up for discussion: right now, when an internal server error occurs, the logged error is not really useful for the user.
For example, a
KeyErrorwill only print the missing key instead of the full stacktrace and error.Adding it to the common error handler as that one is meant to catch all remaining errors,
HTTPExceptions are handled by another error handler.Another option would be to do like
FlaskandStarletteby adding adebugoption, but that seems a lot of work while this current solution doesn't really have big downsides (?)