Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flask 0.11 #240

Merged
merged 2 commits into from
Jun 3, 2016
Merged

Conversation

rafaelcaricio
Copy link
Collaborator

Fixes #239
Replaces #237

Simple change makes Connexion compatible with Flask 0.11

Since the Flask 0.11 the supported error handlers are the ones that have specific exception in werkzeug. The HTTP error code 402 is not supported by Werkzeug so we cannot use it in tests.

Changes proposed in this pull request:

  • Calls properly the add_error_handler funcion from Flask App
  • Fix tests

@coveralls
Copy link

coveralls commented Jun 3, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling e387118 on rafaelcaricio:support-flask-0.11 into a83598d on zalando:master.

@jmcs
Copy link
Contributor

jmcs commented Jun 3, 2016

Don't forget to update the requirements.

@rafaelcaricio
Copy link
Collaborator Author

rafaelcaricio commented Jun 3, 2016

@jmcs We still support 0.10.1 so there is no reason to update our requirements since it uses Flask>=0.10.1.

@rafaelcaricio
Copy link
Collaborator Author

@jmcs also there is a test env to guarantee that we run tests in the version 0.10.1 of Flask.

@jmcs
Copy link
Contributor

jmcs commented Jun 3, 2016

👍

1 similar comment
@hjacobs
Copy link
Contributor

hjacobs commented Jun 3, 2016

👍

@hjacobs hjacobs merged commit 850c035 into spec-first:master Jun 3, 2016
@jmcs jmcs removed the in progress label Jun 3, 2016
@rafaelcaricio rafaelcaricio deleted the support-flask-0.11 branch June 3, 2016 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants