Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's bad practice to derive custom exception classes from BaseException. #276

Merged
merged 1 commit into from
Sep 8, 2016
Merged

It's bad practice to derive custom exception classes from BaseException. #276

merged 1 commit into from
Sep 8, 2016

Conversation

jfinkhaeuser
Copy link
Contributor

Changes proposed in this pull request:

Note: the latter change is in line with how exceptions are generally handled in connexion. It'd be easy enough to pass this particular error through anyway.

@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f804a96 on jfinkhaeuser:no-base-exception into 52ec049 on zalando:master.

@rafaelcaricio
Copy link
Collaborator

👍

@hjacobs hjacobs merged commit ec1ad38 into spec-first:master Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants