Improve metrics reporting #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtkav
reviewed
Sep 7, 2018
connexion/decorators/metrics.py
Outdated
| @@ -30,16 +32,19 @@ def __call__(self, function): | |||
|
|
|||
| @functools.wraps(function) | |||
| def wrapper(request): | |||
| status_code = 500 | |||
| status = 'unknown-exception' | |||
There was a problem hiding this comment.
FWIW I can imagine this being a big pain for someone trying parse logs who expects the status to always be an integer.
There was a problem hiding this comment.
I think I'd still default this to 500, what do you think?
There was a problem hiding this comment.
I also expect it to be 500, since that's what makes sense from an end-2-end visibility point of view.
jmcs
approved these changes
Sep 7, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #665 .
Changes proposed in this pull request: