Don't let openapi_spec_validator tamper raw spec

[cziebuhr]

openapi_spec_validator adds x-scope to schemas with $ref, which then also get served in swagger.json.

"$ref" : "#/definitions/Container",
"x-scope" : [
   "",
   "#/definitions/InstanceStats"
]

In my case, bravado (which internally uses swagger_spec_validator) fails using the spec:

jsonschema.exceptions.RefResolutionError: unknown url type: ''

[dtkav]

What about using the spec that's passed in, and moving validation before resolving refs?
That would avoid another deepcopy.

     def __init__(self, raw_spec):
         self._raw_spec = copy.deepcopy(raw_spec)
         spec = self._set_defaults(raw_spec)
         spec = self._validate_spec(spec)
         self._spec = resolve_refs(spec)

[cziebuhr]

That's also possible, if it's ok that the passed dict will get changed.

[dtkav]

it is already changed by the ref resolver, so I think the only risk is that the validator and ref resolver have some interaction.

…

On Thu, Nov 8, 2018, 9:52 AM Christoph Ziebuhr ***@***.***> wrote: That's also possible, if it's ok that the passed dict will get changed. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#762 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlPSeTo4z36lhz1hxxU9RaRTUeejGJHks5utG9YgaJpZM4YUpWO> .

[dtkav]

Awesome!

[jmcs]

👍