Enforce that spec has string keys (JSON does not support integer keys) #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtkav
changed the title
jmcs
approved these changes
Nov 9, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #756
Spec files are typically written in YAML, which allows keys to be integers.
We convert specs to JSON and serve them up through the API. JSON does not support integer keys.
Previously we were using the ExtendedSafeLoader when reading in YAML files, but this meant that users who loaded their specs manually with yaml.safe_loader() were still at risk of having integer keys.
Rather than force the user to use the ExtendedSafeLoader, this diff recurses through the spec and casts integer keys to string, regardless of if it came from a dict, or file path.
Changes proposed in this pull request: