Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swagger_ui_config option to pass config to the Swagger UI #948

Merged

Conversation

christiansiegel
Copy link
Contributor

Fixes #841 by add an option swagger_ui_config to pass config parameters to the Swagger UI .

This is done by providing a swagger-ui-config.json endpoint with the contents of the swagger_ui_config option. This file is then referenced via the configUrl parameter in the Swagger UI index.j2 template.

Changes proposed in this pull request:

  • Add swagger_ui_config option to pass config parameters to the Swagger UI

There was no possibility to configure the Swagger UI. Through
this new option a config object can be passed to the UI via
a `swagger-ui-config.json` file.
@dtkav
Copy link
Collaborator

dtkav commented Jun 19, 2019

This is a great idea! Nice work.
Can you please add a few tests that try to hit the new endpoint based on config existing / not existing?

Copy link
Collaborator

@dtkav dtkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dtkav
Copy link
Collaborator

dtkav commented Nov 5, 2019

@hjacobs can you take a look at this one when you get a chance? It will help clean up the interface with the swagger-ui-bundle package.

@hjacobs
Copy link
Contributor

hjacobs commented Nov 5, 2019

👍

@hjacobs hjacobs merged commit 67f48ae into spec-first:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to DISPLAY_OPERATION_ID=false?
3 participants