Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version - fxTWAPLS v0.1.2 #21

Merged
merged 44 commits into from
Nov 25, 2022
Merged

New version - fxTWAPLS v0.1.2 #21

merged 44 commits into from
Nov 25, 2022

Conversation

ml4418
Copy link
Contributor

@ml4418 ml4418 commented Nov 21, 2022

No description provided.

@ml4418 ml4418 requested a review from villegar November 21, 2022 16:10
Copy link
Member

@villegar villegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good, thank you! I'm just going to do some minor styling tweaks before sending out to the CRAN

@ml4418
Copy link
Contributor Author

ml4418 commented Nov 21, 2022 via email

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (44788f9) compared to base (66ddaf1).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 44788f9 differs from pull request most recent head 177cba1. Consider uploading reports for the commit 177cba1 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #21   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines         770     766    -4     
======================================
+ Misses        770     766    -4     
Impacted Files Coverage Δ
R/fxTWAPLS.R 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@villegar villegar changed the title Dev New version - fxTWAPLS v0.1.2 Nov 25, 2022
@villegar villegar merged commit d60d422 into master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants