Skip to content

Commit

Permalink
Fix more typos
Browse files Browse the repository at this point in the history
  • Loading branch information
joshtemple authored and DylanBaker committed Mar 15, 2022
1 parent b9ef097 commit 24bf8e0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
6 changes: 3 additions & 3 deletions spectacles/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def main():
log_dir=args.log_dir,
project=args.project,
ref=ref,
explores=[restore_dash(arg) for arg in args.explores],
filters=[restore_dash(arg) for arg in args.explores],
base_url=args.base_url,
client_id=args.client_id,
client_secret=args.client_secret,
Expand All @@ -286,7 +286,7 @@ def main():
run_assert(
project=args.project,
ref=ref,
explores=[restore_dash(arg) for arg in args.explores],
filters=[restore_dash(arg) for arg in args.explores],
base_url=args.base_url,
client_id=args.client_id,
client_secret=args.client_secret,
Expand All @@ -298,7 +298,7 @@ def main():
run_content(
project=args.project,
ref=ref,
explores=[restore_dash(arg) for arg in args.explores],
filters=[restore_dash(arg) for arg in args.explores],
base_url=args.base_url,
client_id=args.client_id,
client_secret=args.client_secret,
Expand Down
24 changes: 12 additions & 12 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def test_config_file_explores_folders_processed_correctly(
}
with patch("sys.argv", ["spectacles", "sql", "--config-file", "config.yml"]):
main()
assert mock_run_sql.call_args.kwargs["explores"] == [
assert mock_run_sql.call_args.kwargs["filters"] == [
"model_a/*",
"-model_a/explore_b",
]
Expand All @@ -206,7 +206,7 @@ def test_cli_explores_folders_processed_correctly(mock_run_sql, clean_env):
],
):
main()
assert mock_run_sql.call_args.kwargs["explores"] == [
assert mock_run_sql.call_args.kwargs["filters"] == [
"model_a/*",
"-model_a/explore_b",
]
Expand Down Expand Up @@ -401,11 +401,11 @@ def test_main_with_connect(mock_tracking, mock_run_connect, env):
)
mock_tracking.track_invocation_end.assert_called_once()
mock_run_connect.assert_called_once_with(
"BASE_URL_ENV_VAR", # base_url
"CLIENT_ID_ENV_VAR", # client_id
"CLIENT_SECRET_ENV_VAR", # client_secret
8080, # port
3.1, # api_version
base_url="BASE_URL_ENV_VAR",
client_id="CLIENT_ID_ENV_VAR",
client_secret="CLIENT_SECRET_ENV_VAR",
port=8080,
api_version=3.1,
)


Expand All @@ -417,11 +417,11 @@ def test_main_with_do_not_track(mock_tracking, mock_run_connect, env):
mock_tracking.track_invocation_start.assert_not_called()
mock_tracking.track_invocation_end.assert_not_called()
mock_run_connect.assert_called_once_with(
"BASE_URL_ENV_VAR", # base_url
"CLIENT_ID_ENV_VAR", # client_id
"CLIENT_SECRET_ENV_VAR", # client_secret
8080, # port
3.1, # api_version
base_url="BASE_URL_ENV_VAR",
client_id="CLIENT_ID_ENV_VAR",
client_secret="CLIENT_SECRET_ENV_VAR",
port=8080,
api_version=3.1,
)


Expand Down

0 comments on commit 24bf8e0

Please sign in to comment.