Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental SQL validation #414

Closed
wants to merge 43 commits into from
Closed

Incremental SQL validation #414

wants to merge 43 commits into from

Conversation

joshtemple
Copy link
Collaborator

@joshtemple joshtemple commented Sep 15, 2021 •
edited
Loading

Change description

Description to come once draft work is finished

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Closes #48, closes #371, closes #369

Checklists

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

@joshtemple
Ignore Pyright config file
2dc9ea7
@joshtemple
Update pre commit to match requirements.txt
a263c19
@joshtemple
Update abstract interface for validators
6341789
@joshtemple
Remove project from all_folders args
bb679d1
@joshtemple
Rework content validator to return errors directly
b09e215 
Also removes the parent Validator class entirely, which was violating Liskov substitution principle and frankly wasn't very useful as a parent class anyway.
@joshtemple
Move public method to the top
f384c0c
@joshtemple
Fix mypy config in pre-commit
139d0ed
@joshtemple
Fix content validation tests
eb4a3a1 
Includes moving build_project to its own method in lookml.py and an update to explore selection that uses a ~/repos/spectacles to represent excluded explores in a single list instead of using two lists (selectors/exclusions) to represent.
@joshtemple
Rework data test validator to return errors directly
cad6bf8
@joshtemple
Fix cassette names
eebdd37
@joshtemple
Use validator's client instead of fixture
5cfb999
@joshtemple
Update data test validator tests
1467e3f
@joshtemple
Simplify skipping in loop
1c74eba
@joshtemple
Add method to iterate through explores in project
462df2d
@joshtemple
Allow explores to be in a skipped state
96be6aa
@joshtemple
Update runner method for data tests
1cdaa66
@joshtemple
Update runner method for content validator
98f1365
@joshtemple
Remove QueryMode type
39def00
@joshtemple
Apply errors to the project as well as returning
ee88b82
@joshtemple
Use fail fast instead of query mode
e26d8c3
@joshtemple
Update branch manager to handle ephemeral correctly
c986e5e
@joshtemple
Add run query method to client
7aa9f1f
@joshtemple
Add incremental SQL implementation
d747629
@joshtemple
Make test creation its own method
eff1903
@joshtemple
Restore deleted line for query result handling
5732737
@joshtemple
Use safer default args
60bddd0
@joshtemple
Fix bug in repr
1afb25a
@joshtemple
Update tests for SQL validation
0f81666 
I chose to remove the tests that included warnings. Fail and Pass should be sufficient.
@joshtemple
Update select tests to new filters logic
00b91e8
@joshtemple
Don't include models without selected explores
9372f0f
@joshtemple
Update client tests for and
7cffc4d
@joshtemple
Move build project tests to test_lookml
64b30d0
@joshtemple
Create client outside of Runner constructor
8021c28
@joshtemple
Add defaults for ref and filters for data/content validators
3eba9db
@joshtemple
Revert printing of SQL validation errors to old approach
c3da7f8
@joshtemple
Add some basic tests for naive runner usage
eb6c5b1
@joshtemple
Test JSON schema is correct
95741d5
@joshtemple
Parameterize test on fail fast
b66f731
@joshtemple
Fix bug in validate_sql
d44f327 
Didn't set dimension tests correctly in non-incremental case.
@joshtemple
Fix bug in SqlTest __eq__
85f3845 
Because .sql can sometimes be None (non incremental-case) this was causing all SqlTests to be equal, causing some really weird errors in how we removed tests from the  attribute.
@joshtemple
Remove test that is no longer valid
0673ef4
@joshtemple
Use loops instead of set operations
1ed54fe 
Set operations are problematic here because we don't have control over which object is returned (from set A or set B). This is important because we only want to use the objects from the base project, not the target project.
@joshtemple
Change logic on creating dimension tests
502b2fa
@joshtemple joshtemple closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanBaker DylanBaker Awaiting requested review from DylanBaker DylanBaker will be requested when the pull request is marked ready for review DylanBaker is a code owner

@Hawk94 Hawk94 Awaiting requested review from Hawk94 Hawk94 will be requested when the pull request is marked ready for review Hawk94 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@joshtemple