Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LookML Validator to Spectacles #422

Merged
merged 19 commits into from
Jan 10, 2022
Merged

Conversation

DylanBaker
Copy link
Collaborator

@DylanBaker DylanBaker commented Oct 1, 2021

Change description

This PR adds a LookML validator to Spectacles. It adds a new lookml command to the CLI that runs the LookML validator and returns any errors and warnings.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Closes #413, closes #309

Checklists

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

Copy link
Collaborator

@joshtemple joshtemple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great to me, but can you please add tests? Want to see passing and failing cases working as expected.

@DylanBaker DylanBaker marked this pull request as ready for review January 5, 2022 08:50
@@ -1 +1 @@
__version__ = "1.2.0rc3"
__version__ = "1.2.0rc4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make sure we tag this as well once we merge it.

spectacles/client.py Outdated Show resolved Hide resolved
Co-authored-by: Josh Temple <8672171+joshtemple@users.noreply.github.com>
@joshtemple joshtemple merged commit aea2b45 into master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a LookML validator Lint command to validate project markup.
2 participants