-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LookML Validator to Spectacles #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great to me, but can you please add tests? Want to see passing and failing cases working as expected.
@@ -1 +1 @@ | |||
__version__ = "1.2.0rc3" | |||
__version__ = "1.2.0rc4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just make sure we tag this as well once we merge it.
Co-authored-by: Josh Temple <8672171+joshtemple@users.noreply.github.com>
Change description
This PR adds a LookML validator to Spectacles. It adds a new
lookml
command to the CLI that runs the LookML validator and returns any errors and warnings.Type of change
Related issues
Closes #413, closes #309
Checklists
Security
Code review