Fix issue with exclusions in config files and env vars #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Previously, we were converting leading dashes in
--explores
and--folders
args into tildes so they wouldn't break argparse. However, this meant we built our exclusion logic deeper in the application off of leading~
instead-
. For args passed via the config file or environment variables, preprocessing wasn't happening, so the leading dashes were not being converted to tildes.Rather than keep everything in tildes, I thought it would be better to simply "undo" the preprocessing for command-line arguments after parsing is done.
This reverts the validator logic back to using
-
instead of~
, cleaning up the tilde-prepended args before they're passed out of the CLI. This also makes tests more readable.Description here
Type of change
Related issues
Closes #526
Checklists
Security
Code review