Handle content errors without a folder #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtemple
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Thanks for the PR @michael-erasmus! This looks great, I'll merge it in.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Using spectacles on my company's Looker instance, I ran into error caused by (I think) the same issue as reported here: #327
The PR to fix this issue didn't seem to work in my case though, since the call to
content[content_type]["folder"]returns aNone, it's thefolderthat's not set, not theidattribute.This change fixed the error for me locally.
Type of change
Related issues
Closes #327
Code review