Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_lookml_test to use proper request method #596

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

DylanBaker
Copy link
Collaborator

Change description

There was a call in the run_lookml_test function that was using Session.get instead of self.get. This PR fixes that and adds a test.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Closes #595

Checklists

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

@DylanBaker DylanBaker added Bug Something isn't working Validator: Assert labels Jul 14, 2022
@DylanBaker DylanBaker self-assigned this Jul 14, 2022
@DylanBaker DylanBaker marked this pull request as ready for review July 14, 2022 10:47
@DylanBaker
Copy link
Collaborator Author

@joshtemple Have we pre-emptively changed the required statuses ahead of the async merge? Seeing that it's expecting integration and unit which aren't currently parts of the CircleCI job on master.

@joshtemple
Copy link
Collaborator

joshtemple commented Jul 14, 2022 via email

@DylanBaker DylanBaker merged commit e4f7a43 into master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Validator: Assert
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_lookml_test is using incorrect request method
2 participants