Fix profiling and open it back up to all queries #706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes a bug where profiling did not work at all and expands profiling to be allowed for all queries again, not just fail fast queries.
It's important to note that the profiler results are a bit harder to interpret now that we use binary search. Previously, we had N + 1 queries for each Explore (one that selected all dimensions and one for each dimension). So a query either had exactly N dimensions or 1 dimension.
Now, a query can have any number of dimensions between 1 and N. I've basically handwaved this by returning "*" for the
Dimension(s)
column in the profiler output whenever a query has more than 1 dimension. It's worth documenting that this means "more than one" and not necessarily "all". I thought this was better than trying to print an arbitrarily long list of dimensions, but open to feedback.Type of change
Related issues
Closes #653.
Checklists
Security
Code review