Extend HTTP timeout #803
Merged
Extend HTTP timeout #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanBaker
reviewed
May 13, 2024
There was a problem hiding this comment.
@joshtemple doesn't this get over-ridden by the timeout on each request?
|
Yes, and I'm still not sure why I'm seeing a 5 sec |
|
Yeah, I'm good with that. |
This reverts commit 1f0252f.
Extends retries to all httpx.NetworkError (which will include ReadError) and increases the number of retries in the case of network errors while giving up for all non-502 status errors
joshtemple
force-pushed
the
josh/extend-http-timeout
branch
from
9358a64
to
1972cff
Compare
DylanBaker
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
We were not backing off and retrying on manifest changes, which was by design since often the manifest is not there and we don't want to retry a 404. However, we can still retry timeouts, so I've added backoff for that endpoint for timeouts but not status errors.
We were not backing off and retrying on
httpx.ReadError, so I've used the parent classNetworkErrorto catch this in our backoff logic.We were only retrying most requests 3 times by default. With exponential backoff, this isn't waiting that long in total. I've increased the number of retries to 10 for any network error or 502 status. I've ensured we give up immediately and don't retry on status error that isn't a 502.
Type of change
Related issues
Checklists
Security
Code review