modified tokenizer to not break on on ]]] at the end of a style #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-a
force-pushed
the
bugfix/GH-1024
branch
from
f97d9b2
to
2c5dfe9
Compare
patriksvensson
approved these changes
Dec 1, 2022
|
Merged! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@patriksvensson, @phil-scott-78 can't say I like this change, but it gets the job done for the moment.
There are two things I don't like in particular:
StringBuilder.ToString()in a loop feels weird. Not sure if it would easier/better/more performant to drop theStringBuilderhere and simply concatenate the chars together.I'd appreciate any input.