Add option to configure the style of the choices list and the default value in TextPrompt #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@ap0llo sorry for the late reply. As to the tests: There are currently no tests for styling of the |
Add property "DefaultValueStyle" to TextPrompt which allows setting the style in which the default value is rendered. When no style is set, the value is displayed as green text, keeping the existing behavior.
Add property "ChoicesStyle" to TextPrompt which allows setting the style in the prompt's choices are rendered. When no style is set, choices are displayed as blue text, keeping the existing behavior.
ap0llo
force-pushed
the
textprompt-styling
branch
from
db59e58
to
e8fd29d
Compare
|
@nils-a I added some simple unit tests to ensure the styles are applied |
|
@ap0llo your changes have been merged, thanks for your contribution 👍 |
This was referenced Mar 27, 2022
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextPrompt currently uses a fixed style for the default value (green text) and the list of choices (blue text).
This PR adds two new properties to TextPrompt (
DefaultValueStyleandChoicesStyle) that allow customozing the style of these values.If no styles are set, the current green & blue values continue to be used.
Note: I'm unsure if there are tests that cover the styling of TextPrompt. If there is a place I can add a test for this, it would be great if you could point me in the right direction.