Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overload with params array for AddChoiceGroup() #682

Merged

Conversation

Sir-Baconn
Copy link
Contributor

@Sir-Baconn Sir-Baconn commented Jan 7, 2022

Adds overloads to MultiSelectionPrompt.AddChoiceGroup() and SelectionPrompt.AddChoiceGroup() taking in params T[]. Similar methods like AddChoices() had this option but these did not.

Resolves #690

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2022

CLA assistant check
All committers have signed the CLA.

@nils-a
Copy link
Contributor

nils-a commented Jan 13, 2022

@Sir-Baconn could you please add an issue for this "problem", so we can track the changes a bit better?

@Sir-Baconn
Copy link
Contributor Author

@Sir-Baconn could you please add an issue for this "problem", so we can track the changes a bit better?

Thanks, I have added #690

Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nils-a nils-a merged commit f221c1f into spectreconsole:main Jan 15, 2022
@nils-a
Copy link
Contributor

nils-a commented Jan 15, 2022

@Sir-Baconn your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add overloads accepting params[] for choices in choice groups for selection prompts
3 participants