-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves exception rendering for async methods in .NET 6 #718
Improves exception rendering for async methods in .NET 6 #718
Conversation
3a1d05b
to
02dcd4a
Compare
Nice improvement, but this is going to conflict hard with #695. 😦 |
Totally missed that PR. I suspect it wouldn't be terribly difficult for me to redo things to make it work on top of it, but I'd have to move a lot of the processing logic a lot closer to the rendering if I don't have the extra classes to smuggle the parsed data around. Then again, it's not like we have a ton of use for the parsed data elsewhere so that might actually end up being a slightly cleaner solution altogether |
Ok, I looked at @0xced PR and building this on top of it I think it's the way to go. @patriksvensson and @nils-a if you all don't have any objections, I'm going to merge it and redo this PR on top of it. |
@phil-scott-78 No objections from me! |
Great. I've merged the other PR and I'll redo this one! Thanks for the heads up @0xced |
02dcd4a
to
f4d6b8c
Compare
ok, redid this on top of @0xced work. Thanks again for the heads up. I quite like how they both came together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
.NET 6 includes a new attribute that makes it easy to filter out stack frames we don't want to include. We can also improve upon the name of the method displayed when working with async calls.
Before
After
Fallback
Previous versions of .NET without the attribute still work and have better method names with async calls, but the additional stack frames are still included