Charts api reworked #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromel777
reviewed
Aug 5, 2022
| val value: String, | ||
| val dateFormat: String, | ||
| val timeWindow: FiniteDuration, | ||
| val pgValue: Int, |
Bromel777
reviewed
Aug 5, 2022
.../markets-api/src/main/scala/org/ergoplatform/dex/markets/api/v1/models/charts/ChartGap.scala
Outdated
Show resolved
Hide resolved
|
please, squash commits |
GusevTimofey
force-pushed
the
charts-api-reworked
branch
from
b60ff44 to
18fcb97
Compare
oskin1
approved these changes
Aug 17, 2022
| @@ -81,6 +82,27 @@ final class AmmStatsEndpoints(conf: RequestConfig) { | |||
| .name("Pool chart") | |||
| .description("Get price chart by pool") | |||
|
|
|||
| def getPoolPriceChartWithGaps: Endpoint[(PoolId, TimeWindow, ChartGap), HttpError, List[PricePoint], Any] = | |||
| baseEndpoint.get | |||
| .in(PathPrefix / "pool" / path[PoolId].description("Asset reference") / "charts") | |||
| from <- window.from | ||
| to <- window.to | ||
| period = to - from | ||
| } yield if (period > gap.minimalGap) false else true).getOrElse(true) |
There was a problem hiding this comment.
Suggested change
| } yield if (period > gap.minimalGap) false else true).getOrElse(true) | |
| } yield period <= gap.minimalGap).getOrElse(true) |
GusevTimofey
force-pushed
the
charts-api-reworked
branch
from
cc5be10 to
e065d72
Compare
GusevTimofey
force-pushed
the
charts-api-reworked
branch
from
e065d72 to
8d0c414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.