LM parallel rewards support #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskin1
reviewed
Sep 19, 2023
| val poolLQ0 = SELF.tokens(2) | ||
| val poolVLQ0 = SELF.tokens(3) | ||
| val poolTMP0 = SELF.tokens(4) | ||
| val poolOptReward0 = SELF.tokens(5) |
There was a problem hiding this comment.
If the asset at this index is supposed to be optional, then I guess it can be absent. This code fails in that case.
There was a problem hiding this comment.
Yes, at least 1 optional reward token must be added during the initialisation with it's redeemer in the R5.
| val budgetsNotDepleted = poolMainReward1._2 != 0 && poolOptReward0._2 != 0 | ||
|
|
||
| if ( | ||
| (deltaMainReward > 0 || deltaOptReward > 0) && !budgetsNotUpdated && budgetsNotDepleted |
There was a problem hiding this comment.
Budget can be increased only in the case opt token is initialized and not depleted?
There was a problem hiding this comment.
Same, depleted means 0 tokens, which is impossible during normal program operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of main changes: