Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version checking to avoid deprecation warning in load_csa (#883) #887

Conversation

KirilBourakov
Copy link
Contributor

Added version checking as described by #883 . I'm working under the assumption that 'fully_trusted' is correct here, as documentation tells me that matches the functionality of previous versions of python.

If there are any issues, please let me know and I'll do my best to fix.

@jameswilburlewis
Copy link
Contributor

Thanks for contributing! I finally remembered that the test script won't run to completion for most pull requests, because your fork doesn't have the MMS team credentials stored as github secrets. But your changes look good, so I'll go ahead and merge them in.

@jameswilburlewis jameswilburlewis merged commit 0d63ae4 into spedas:master Jun 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants