Export GetFlushReasonString/GetCompactionReasonString in listener.h #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@git-hulk Thank you for contributing! Can you please rebase? Thank you |
git-hulk
force-pushed
the
export-flush-compact-reason-string
branch
from
5ce6923
to
256b479
Compare
git-hulk
force-pushed
the
export-flush-compact-reason-string
branch
from
256b479
to
cc4cf8d
Compare
|
@ofriedma Done |
|
@ofriedma Should I worry about this CI failure? |
ofriedma
previously approved these changes
Dec 28, 2023
|
@git-hulk could you please resolve the conflicts? |
ofriedma
approved these changes
Jan 2, 2024
|
@ofriedma done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetFlushReasonString/GetCompactionReasonString are exported in rocksdb(PR #11778)
and Apache Kvrocks would like to use them to avoid copying those reason strings: apache/kvrocks#1962