Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update ITestResultSeralizer to accept messages. #19

Merged
merged 7 commits into from
Apr 4, 2021

Conversation

Siphonophora
Copy link
Contributor

@Siphonophora Siphonophora commented Mar 30, 2021

Pass messages to seralizer as discussed in spekt/junit.testlogger#33

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #19 (9cba3ff) into master (f5704c0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          502       503    +1     
=========================================
+ Hits           502       503    +1     
Impacted Files Coverage Δ
src/TestLogger/Core/TestRunCompleteWorkflow.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5704c0...9cba3ff. Read the comment docs.

@Siphonophora Siphonophora marked this pull request as ready for review March 31, 2021 00:37
@Siphonophora
Copy link
Contributor Author

@codito So, this is pretty simple. I was a bit surprised by the two tests that were failing. I think those are just windows specific issues.

Let me know if you think I should add tests to this. The part I care about for junit will be covered by the unit test that is currently failing in spekt/junit.testlogger#33

Copy link
Contributor

@codito codito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks! Will add a windows CI soon.

@codito
Copy link
Contributor

codito commented Apr 1, 2021

It will be good to add a test. May be we can update the JsonTestResultSerializer output schema to include messages: https://github.com/spekt/testlogger/blob/master/test/TestLogger.UnitTests/TestDoubles/JsonTestResultSerializer.cs#L20, this will allow us to assert the output content in TestRunCompleteWorkflowTests.

@Siphonophora
Copy link
Contributor Author

How about this as an option. Its simpler than putting messages in the JSON. Any downside to this?

@codito
Copy link
Contributor

codito commented Apr 1, 2021

JsonTestResultSerializer is also part of the json test logger which is used in Acceptance Tests. With this approach, we may not be able to validate messages as part of an acceptance test (in future).

@Siphonophora
Copy link
Contributor Author

Yep makes sense. We should be all set now.

Note, I dropped traits from the sample json, since they aren't in the Test model.

@codito
Copy link
Contributor

codito commented Apr 4, 2021

Looks perfect! Thanks.

@codito codito merged commit 365fc23 into spekt:master Apr 4, 2021
@Siphonophora Siphonophora deleted the Provide-messages-to-seralizers branch April 4, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants