-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Update ITestResultSeralizer to accept messages. #19
Feat: Update ITestResultSeralizer to accept messages. #19
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 502 503 +1
=========================================
+ Hits 502 503 +1
Continue to review full report at Codecov.
|
@codito So, this is pretty simple. I was a bit surprised by the two tests that were failing. I think those are just windows specific issues. Let me know if you think I should add tests to this. The part I care about for junit will be covered by the unit test that is currently failing in spekt/junit.testlogger#33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks! Will add a windows CI soon.
It will be good to add a test. May be we can update the |
How about this as an option. Its simpler than putting messages in the JSON. Any downside to this? |
|
Yep makes sense. We should be all set now. Note, I dropped traits from the sample json, since they aren't in the |
Looks perfect! Thanks. |
Pass messages to seralizer as discussed in spekt/junit.testlogger#33