Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #296
Changes vs the original PR:
master
client
as its base abstraction, notbucket
=> bucket is thus a part of path, the first component in it (!)0755
Bonus:
gs://<bucket>/<path>
URLs too, even though it's explicitly excluded from tests, sinceafero
in general does not work with URLs.The original PR notes, which still apply to this version of the implementation + extra for this version:
Limitations:
Performance implications