Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example code of generating Zsh completion #1005

Closed
wants to merge 1 commit into from

Conversation

autopp
Copy link

@autopp autopp commented Dec 24, 2019

Current zsh_completion.md only shows what cobra supports for generating Zsh completion, not how to do id. So I added basic usage.

I hope this help.

@jharshman jharshman added the kind/documentation Documentation of cobra itself label Dec 26, 2019
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@wfernandes
Copy link
Collaborator

@autopp Thanks for this PR.
@jpmcb Can you take a look at this since you recently did some zsh testing? 😉

@jpmcb
Copy link
Collaborator

jpmcb commented Apr 15, 2020

Hi @autopp thanks for this PR!

I'm thinking this may have to wait a bit for this to get merged: #1070.

With #1035 being merged and #1048 also getting in, looks like zsh will be the next to get the "Go completions" facelift. So stay tuned! I'll check back in with this PR after those are merged

@github-actions
Copy link

This PR is being marked as stale due to a long period of inactivity

@marckhouzam
Copy link
Collaborator

@autopp The documentation for shell completion has extensively changed recently. An example of generating the different completion scripts can be found here:
https://github.com/spf13/cobra/blame/884edc58ad08083e6c9a505041695aa2c3ca2d7a/shell_completions.md#L56

If you find that the doc now addresses your concern, would you mind closing this PR? Thank you.

@autopp
Copy link
Author

autopp commented Jul 14, 2020

@marckhouzam The current doc seems to address my concern. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation of cobra itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants