Add Labeler Actions #1074
Add Labeler Actions #1074
Conversation
this will label PRs such that the maintainers have visibility into the breadth of the changes being suggested
|
|
jharshman
added
the
kind/feature
.github/labeler.yml
Outdated
| "area/lib": ./*.go | ||
|
|
||
| # changes to the zsh completion | ||
| "area/*sh completion": ./zsh* |
There was a problem hiding this comment.
Can we match on the bash completion as well?
There was a problem hiding this comment.
👍
just added the matchers for the other autocompletion shells
| steps: | ||
| - uses: actions/labeler@v2 | ||
| with: | ||
| repo-token: "${{ secrets.GITHUB_TOKEN }}" |
There was a problem hiding this comment.
Is this secret something I need to configure?
There was a problem hiding this comment.
I don't believe you need to do anything no.
There was a problem hiding this comment.
FWIW, from #952 (comment):
Better integration of permissions. Since Actions is built in GitHub, it is possible to use secret tokens without explicitly managing/setting them.
By the same token, as suggested in #959, it should be possible to parse the body of PRs to have them self-labelled by contributors.
any changes to and autocomplete for any shell will now be auto labelled as impacting the autocompletion functionality
|
|
||
| # changes to the core lib package | ||
| "area/lib": ./*.go | ||
|
|
There was a problem hiding this comment.
What about one for the Cobra Generator itself?
# changes to the cobra generator
"area/cobra-generator": cobra/**/*
There was a problem hiding this comment.
I didn't see that label in the current set.
Maybe we have a enhancement PR to add more labels and matchers?
@jpmcb
adds labeling actions
when certain parts of the code are modified by a
PR then the corresponding label is added