Make bash completion provide sub-command names even if ValidArgs present #1088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1076
This PR makes bash completion also provide sub-command names when
ValidArgs
orValidArgsFunction
are specified.Here are details about the completions given:
Cobra's Bash completion:
Original (before custom Go completions of PR #1035):
ValidArgs
XORsub-commands
(which means it givesValidArgs
and if there are none, then it givessub-commands
)Current:
ValidArgs
XORValidArgsFunction
XORsub-commands
With this PR:
ValidArgs
ANDsub-commands
) XOR (ValidArgsFunction
ANDsub-commands
)For info, Cobra's Zsh completion does it yet another way:
sub-commands
XORValidArgs
Which which should align eventually.