-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Go < 1.14 #1323
Deprecate Go < 1.14 #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also need changes in go.mod
? I see
go 1.12
Will this need to be updated to 1.14?
@jpmcb good catch, yes that should be updated as well. |
@jharshman, please, go ahead with this. I will then rebase and cleanup on top of master. Adding golangci-lint and so is not strictly related to this, but it will make it easier if I can focus on >1.11 features only. FTR, I did split the initial golangci-lint into two PRs for keeping >1.11 features isolated. Now, both can be merged again, so I will close one of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet - Thanks @jharshman looks good to me! 👍
In accordance with our adopted best practices, the main branch and the next major release of Cobra will deprecate older and un-maintained versions of Golang. fix spf13#1322
5ab5cd5
to
16c0de6
Compare
Merging w/o latest CI run. TravisCI still queuing and takes forever. Seems to be related to their switch from .org to .com. |
@jharshman, unfortunately, I don't think it's a transitory issue. The switch from .org to .com has been going on for 2-3 years. However, they recently changed their pricing model. Free resources for open source projects were significantly reduced, and maintainers need to periodically request additional "credits". Since this projects is in spf13's namespace, I guess that only he can see the state of the credits. In practice, most open source projects are migrating from Travis CI to somewhere else, mostly GitHub Actions. |
…ility Resolves "v1.1.2 is not semver compliant" due to deprecation of Go version See #1232 (comment) This reverts commit 1d71ff0.
In accordance with our adopted best practices, the main branch and the
next major release of Cobra will deprecate older and un-maintained
versions of Golang.
fix #1322